linux-ext4 - Re: mostly remove _supported

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240624121730.4d35b58a.ddiss@suse.de>
Date: Mon, 24 Jun 2024 12:17:30 +1000
From: David Disseldorp <ddiss@...e.de>
To: Christoph Hellwig <hch@....de>
Cc: Zorro Lang <zlang@...nel.org>, fstests@...r.kernel.org, "Theodore Ts'o"
 <tytso@....edu>, linux-ext4@...r.kernel.org
Subject: Re: mostly remove _supported_fs

On Sun, 23 Jun 2024 14:10:29 +0200, Christoph Hellwig wrote:

> Hi Zorro,
> 
> this series improves generic/740 and then mostly removes _supported_fs
> as it's largely not needed.
> 
> The exceptions are the negative matches, which should probably be
> replaced with a new _exclude_fs helper, and the test/ext4 directly
> which is also run by magic for ext2 and ext3.  I'm not entirely sure
> what to do about it, but removing this magic and just adding small
> wrappers for ext2 and ext3 to run the ext4 tests would seem like
> the best idea to me.

This whole series looks good to me:
Reviewed-by: David Disseldorp <ddiss@...e.de>

There are many double-empty-lines following the patch 8/8 removals
(btrfs/014, btrfs/031, btrfs/192, btrfs/196, generic/004, etc.) but they
could be cleaned up on merge. Also, "# Modify as appropriate." would
make a good addition to your removal regex.