linux-ext4 - Re: [PATCH 5/8] generic/740: enable by default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240626040153.GA20683@lst.de>
Date: Wed, 26 Jun 2024 06:01:53 +0200
From: Christoph Hellwig <hch@....de>
To: Theodore Ts'o <tytso@....edu>
Cc: Christoph Hellwig <hch@....de>, "Darrick J. Wong" <djwong@...nel.org>,
	Zorro Lang <zlang@...nel.org>, fstests@...r.kernel.org,
	linux-ext4@...r.kernel.org
Subject: Re: [PATCH 5/8] generic/740: enable by default

On Tue, Jun 25, 2024 at 04:05:55PM -0400, Theodore Ts'o wrote:
> Oh, good point.  Yeah, mke2fs uses libblkid in addition to libmagic.
> So yes, it should work for basic detection of file systems for the
> purposes of generic/740.  So the only issue would be the fact that
> mkfs.extN only does the detection if it is running with a tty.  The
> reasoning behind this was that there might have been existing shell
> scripts that might try to reformat a block device over an existing
> file system.  (For example, like file system test / performance
> scripts like, say, for example xfstests's "check" script.  :-)
> 
> What I've considered doing adding an extended option, "mke2fs -E
> existing_fs_test={on,off,auto}" where auto is today's behavior, and
> "on" would always do the pre-existing file system test and fail if it
> there is a pre-existing file system, and "off" would skip it entirely.
> 
> This would allow generic/740 to work without having to depend on
> "script" being installed.  Of course, this would only work if a
> sufficiently new version of mkfs.extN being used by fstests.

Yes, so it's probably not worth it at least for this purpose.

My preference would be to go ahead with the series as-is for now.
I'll see if I can come up with the script magic eventually.