linux-ext4 - Re: [PATCH v2 4/4] jbd2: Drop pointless shrinker batch initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d686bddf-0b8b-d8a3-765d-690a8f6b72f6@huawei.com>
Date: Thu, 27 Jun 2024 15:07:48 +0800
From: Zhang Yi <yi.zhang@...wei.com>
To: Jan Kara <jack@...e.cz>
CC: <linux-ext4@...r.kernel.org>, Alexander Coffin
	<alex.coffin@...icrobots.com>, Ted Tso <tytso@....edu>
Subject: Re: [PATCH v2 4/4] jbd2: Drop pointless shrinker batch initialization

On 2024/6/25 1:01, Jan Kara wrote:
> In jbd2_journal_init_common() we set batch size of a shrinker shrinking
> checkpointed buffers to journal->j_max_transaction_buffers. But that is
> guaranteed to be 0 at that point so we effectively stay with the default
> shrinker batch size of 128. It has been like this since introduction of
> jbd2 shrinkers so just drop the pointless initialization.
> 
> Signed-off-by: Jan Kara <jack@...e.cz>

Looks good to me.

Reviewed-by: Zhang Yi <yi.zhang@...wei.com>

> ---
>  fs/jbd2/journal.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c
> index ae5b544ed0cc..c356cc027ed7 100644
> --- a/fs/jbd2/journal.c
> +++ b/fs/jbd2/journal.c
> @@ -1641,7 +1641,6 @@ static journal_t *journal_init_common(struct block_device *bdev,
>  
>  	journal->j_shrinker->scan_objects = jbd2_journal_shrink_scan;
>  	journal->j_shrinker->count_objects = jbd2_journal_shrink_count;
> -	journal->j_shrinker->batch = journal->j_max_transaction_buffers;
>  	journal->j_shrinker->private_data = journal;
>  
>  	shrinker_register(journal->j_shrinker);
>