linux-ext4 - Re: [PATCH] jbd2: Add a comment for incorrect tag size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f3473286-cf5f-4708-8a84-524b967772a0@huawei.com>
Date: Fri, 28 Jun 2024 10:15:26 +0800
From: "wangjianjian (C)" <wangjianjian3@...wei.com>
To: Theodore Ts'o <tytso@....edu>
CC: Wang Jianjian <wangjianjian0@...mail.com>, <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH] jbd2: Add a comment for incorrect tag size

On 2024/6/27 21:31, Theodore Ts'o wrote:
> On Thu, Jun 20, 2024 at 11:19:30AM +0800, wangjianjian (C) wrote:
>> On 2024/6/20 7:36, Theodore Ts'o wrote:
>>> bd2: fix descriptor block size handling errors with journal_csum
>>> in 2016 --- a full eight years ago.  So it's probably not worth adding
>> the comment at this point.
>>
>> Thanks for detailed information, but is it better to put it in document in
>> case any other one confuse about this when read code.
> 
> The comment would probably make things more confusing, since there's a
> much larger context involving the fact that csum_v2 is an obsolete
> format that in practice is never used.  Sure, we could make the
> comment even more verbose, but perhaps it would be better to simply
> completely remove csum_v1 and csum_v2 from the code.  That will
> probably make the code even more simpler to read.

Agree with that, if it is ok, I can submit a patch do that.
> 
> Cheers,
> 
> 						- Ted
> 
-- 
Regards