linux-ext4 - Re: [PATCH 0/14] New uid & gid mount option parsing helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240628-diametral-median-bc0de7b68148@brauner>
Date: Fri, 28 Jun 2024 13:51:29 +0200
From: Christian Brauner <brauner@...nel.org>
To: Eric Sandeen <sandeen@...hat.com>
Cc: linux-fsdevel@...r.kernel.org, autofs@...r.kernel.org, 
	"Rafael J. Wysocki" <rafael@...nel.org>, linux-efi@...r.kernel.org, Namjae Jeon <linkinjeon@...nel.org>, 
	linux-ext4@...r.kernel.org, Miklos Szeredi <miklos@...redi.hu>, linux-mm@...ck.org, 
	Jan Kara <jack@...e.cz>, ntfs3@...ts.linux.dev, linux-cifs@...r.kernel.org, 
	linux-trace-kernel@...r.kernel.org, Hans Caniullan <hcaniull@...hat.com>
Subject: Re: [PATCH 0/14] New uid & gid mount option parsing helpers

On Thu, Jun 27, 2024 at 07:24:59PM GMT, Eric Sandeen wrote:
> Multiple filesystems take uid and gid as options, and the code to
> create the ID from an integer and validate it is standard boilerplate
> that can be moved into common helper functions, so do that for
> consistency and less cut&paste.
> 
> This also helps avoid the buggy pattern noted by Seth Jenkins at
> https://lore.kernel.org/lkml/CALxfFW4BXhEwxR0Q5LSkg-8Vb4r2MONKCcUCVioehXQKr35eHg@mail.gmail.com/
> because uid/gid parsing will fail before any assignment in most
> filesystems.
> 
> Net effect is a bit of code removal, as well.

Thanks, this all looks good to me. I'll have one comment about the fuse
patch.