linux-ext4 - Updating i_disksize without acquiring i_data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM70bNa8R5R37KFb=ThD4o7gTkna4goMmGho8tkqrCfZ9LBkGQ@mail.gmail.com>
Date: Tue, 9 Jul 2024 18:16:48 +0530
From: Rohit Singh <rohitsd1409@...il.com>
To: linux-ext4@...r.kernel.org
Subject: Updating i_disksize without acquiring i_data_sem semaphore

Hello.
I am looking around ext4 code and I observed the following issue.

Within ext4_insert_range(), EXT4_I(inode)->i_disksize is being updated
without acquiring i_data_sem.

I have seen code where this operation is done after acquiring
i_data_sem such as in
ext4_update_i_disksize()

So, is this as expected or is it problematic?

Regards,
Rohit