linux-ext4 - Re: [PATCH] ext4: Use memtostr_pad() for s_volume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <172066485809.400039.2045305282487026392.b4-ty@mit.edu>
Date: Wed, 10 Jul 2024 22:35:30 -0400
From: "Theodore Ts'o" <tytso@....edu>
To: Kees Cook <kees@...nel.org>
Cc: "Theodore Ts'o" <tytso@....edu>,
        syzbot+50835f73143cc2905b9e@...kaller.appspotmail.com,
        Justin Stitt <justinstitt@...gle.com>,
        Andreas Dilger <adilger.kernel@...ger.ca>, linux-ext4@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org
Subject: Re: [PATCH] ext4: Use memtostr_pad() for s_volume_name


On Thu, 23 May 2024 15:54:12 -0700, Kees Cook wrote:
> As with the other strings in struct ext4_super_block, s_volume_name is
> not NUL terminated. The other strings were marked in commit 072ebb3bffe6
> ("ext4: add nonstring annotations to ext4.h"). Using strscpy() isn't
> the right replacement for strncpy(); it should use memtostr_pad()
> instead.
> 
> 
> [...]

Applied, thanks!

[1/1] ext4: Use memtostr_pad() for s_volume_name
      commit: be27cd64461c45a6088a91a04eba5cd44e1767ef

Best regards,
-- 
Theodore Ts'o <tytso@....edu>