linux-ext4 - [PATCH] ext4: Use seq_putc() in two functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <076974ab-4da3-4176-89dc-0514e020c276@web.de>
Date: Sat, 13 Jul 2024 20:15:44 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: linux-ext4@...r.kernel.org, kernel-janitors@...r.kernel.org,
 Andreas Dilger <adilger.kernel@...ger.ca>, Theodore Ts'o <tytso@....edu>
Cc: LKML <linux-kernel@...r.kernel.org>
Subject: [PATCH] ext4: Use seq_putc() in two functions

From: Markus Elfring <elfring@...rs.sourceforge.net>
Date: Sat, 13 Jul 2024 17:10:24 +0200

Single characters (line breaks) should be put into a sequence.
Thus use the corresponding function “seq_putc”.

This issue was transformed by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
---
 fs/ext4/mballoc.c | 3 +--
 fs/ext4/super.c   | 2 +-
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
index 9dda9cd68ab2..2008d2d524c9 100644
--- a/fs/ext4/mballoc.c
+++ b/fs/ext4/mballoc.c
@@ -3075,8 +3075,7 @@ static int ext4_mb_seq_groups_show(struct seq_file *seq, void *v)
 	seq_puts(seq, " ]");
 	if (EXT4_MB_GRP_BBITMAP_CORRUPT(&sg.info))
 		seq_puts(seq, " Block bitmap corrupted!");
-	seq_puts(seq, "\n");
-
+	seq_putc(seq, '\n');
 	return 0;
 }

diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index e72145c4ae5a..c8a80cec46a1 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -3045,7 +3045,7 @@ int ext4_seq_options_show(struct seq_file *seq, void *offset)

 	seq_puts(seq, sb_rdonly(sb) ? "ro" : "rw");
 	rc = _ext4_show_options(seq, sb, 1);
-	seq_puts(seq, "\n");
+	seq_putc(seq, '\n');
 	return rc;
 }

--
2.45.2