linux-ext4 - Re: [PATCH 2/2] ext4: Remove array of buffer_heads from mext_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZpmYp-ci47MZ6c9T@casper.infradead.org>
Date: Thu, 18 Jul 2024 23:35:19 +0100
From: Matthew Wilcox <willy@...radead.org>
To: Theodore Ts'o <tytso@....edu>
Cc: Andreas Dilger <adilger.kernel@...ger.ca>, linux-ext4@...r.kernel.org,
	linux-fsdevel@...r.kernel.org, Hannes Reinecke <hare@...e.com>
Subject: Re: [PATCH 2/2] ext4: Remove array of buffer_heads from
 mext_page_mkuptodate()

On Thu, Jun 27, 2024 at 04:20:22PM -0400, Theodore Ts'o wrote:
> This patch is causing ext4/020 (which tests the EXT4_IOC_MOVE_EXT
> ioctl used by e4defrag).  This can be easily reproduced via:
> "kvm-xfstests -c ext4/4k ext4/020".  From
> /results/ext4/results-4k/ext4/020.out.bad:
> 
>    QA output created by 020
>    wrote 1048576/1048576 bytes at offset 0
>    XXX Bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
>    wrote 1023/1023 bytes at offset 0
>    XXX Bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
>    md5sum: WARNING: 1 computed checksum did NOT match
>    SCRATCH_MNT/020.orig: FAILED
> 
> I'm going to drop both this patch and the preceeding patch in this
> series ("ext4: reduce stack usage in ext4_mpage_readpages()") pending
> further investigation.

Thanks.  I couldn't get kvm-xfstests to work, but I was able to run
ext4/020 using Kent's testsuite.  I found two bugs and fixed them.
I split this second patch into three patches for v2.