linux-ext4 - [PATCH] tune2fs.c (main): do not set dirty when default is not changed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20240718175204.1590917-1-gwendal@chromium.org>
Date: Thu, 18 Jul 2024 10:52:04 -0700
From: Gwendal Grignou <gwendal@...omium.org>
To: tytso@....edu
Cc: linux-ext4@...r.kernel.org,
	Gwendal Grignou <gwendal@...omium.org>
Subject: [PATCH] tune2fs.c (main): do not set dirty when default is not changed

If the default group is not modified, don't set the superblock
dirty bit.

Similar to commit 2eb3b20e80, it speeds up `tunefs -g` command when
the group argument is identical.
---
 misc/tune2fs.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/misc/tune2fs.c b/misc/tune2fs.c
index 8ae13705..facc8dc9 100644
--- a/misc/tune2fs.c
+++ b/misc/tune2fs.c
@@ -3382,9 +3382,13 @@ _("Warning: The journal is dirty. You may wish to replay the journal like:\n\n"
 		printf(_("Setting error behavior to %d\n"), errors);
 	}
 	if (g_flag) {
-		sb->s_def_resgid = resgid;
-		ext2fs_mark_super_dirty(fs);
-		printf(_("Setting reserved blocks gid to %lu\n"), resgid);
+		if (sb->s_def_resgid != resgid) {
+			sb->s_def_resgid = resgid;
+			ext2fs_mark_super_dirty(fs);
+			printf(_("Setting reserved blocks gid to %lu\n"), resgid);
+		} else {
+			printf(_("Reserved blocks gid already set to %lu\n"), resgid);
+		}
 	}
 	if (i_flag) {
 		if ((unsigned long long)interval >= (1ULL << 32)) {
-- 
2.45.2.1089.g2a221341d9-goog