linux-ext4 - Re: [PATCH v5.10] ext4: fix error code saved on super block during file system abort

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2024072323-cone-mustard-94b0@gregkh>
Date: Tue, 23 Jul 2024 15:35:29 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Ajay Kaher <ajay.kaher@...adcom.com>
Cc: stable@...r.kernel.org, adilger.kernel@...ger.ca,
	linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org,
	alexey.makhalov@...adcom.com, vasavi.sirnapalli@...adcom.com,
	florian.fainelli@...adcom.com,
	Gabriel Krisman Bertazi <krisman@...labora.com>,
	Theodore Ts'o <tytso@....edu>
Subject: Re: [PATCH v5.10] ext4: fix error code saved on super block during
 file system abort

On Tue, Jul 23, 2024 at 12:17:19PM +0530, Ajay Kaher wrote:
> From: Gabriel Krisman Bertazi <krisman@...labora.com>
> 
> [ Upstream commit 124e7c61deb27d758df5ec0521c36cf08d417f7a ]
> 
> ext4_abort will eventually call ext4_errno_to_code, which translates the
> errno to an EXT4_ERR specific error.  This means that ext4_abort expects
> an errno.  By using EXT4_ERR_ here, it gets misinterpreted (as an errno),
> and ends up saving EXT4_ERR_EBUSY on the superblock during an abort,
> which makes no sense.
> 
> ESHUTDOWN will get properly translated to EXT4_ERR_SHUTDOWN, so use that
> instead.
> 
> Signed-off-by: Gabriel Krisman Bertazi <krisman@...labora.com>
> Link: https://lore.kernel.org/r/20211026173302.84000-1-krisman@collabora.com
> Signed-off-by: Theodore Ts'o <tytso@....edu>
> Signed-off-by: Ajay Kaher <ajay.kaher@...adcom.com>
> ---

Both now queued up, thanks.

greg k-h