linux-ext4 - [PATCH v5.10.y 2/3] samples: Make fs-monitor depend on libc and headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240725153229.13407-3-cel@kernel.org>
Date: Thu, 25 Jul 2024 11:32:28 -0400
From: cel@...nel.org
To: amir73il@...il.com,
	krisman@...labora.com
Cc: gregkh@...uxfoundation.org,
	jack@...e.cz,
	sashal@...nel.org,
	stable@...r.kernel.org,
	adilger.kernel@...ger.ca,
	linux-ext4@...r.kernel.org,
	tytso@....edu,
	alexey.makhalov@...adcom.com,
	vasavi.sirnapalli@...adcom.com,
	florian.fainelli@...adcom.com,
	Guenter Roeck <linux@...ck-us.net>
Subject: [PATCH v5.10.y 2/3] samples: Make fs-monitor depend on libc and headers

From: Gabriel Krisman Bertazi <krisman@...labora.com>

[ Upstream commit 8fc70b3a142f97f7859bf052151df896933d2586 ]

Prevent build errors when headers or libc are not available, such as on
kernel build bots, like the below:

samples/fanotify/fs-monitor.c:7:10: fatal error: errno.h: No such file
or directory
  7 | #include <errno.h>
    |          ^~~~~~~~~

Link: https://lore.kernel.org/r/87fsslasgz.fsf@collabora.com
Suggested-by: Guenter Roeck <linux@...ck-us.net>
Tested-by: Guenter Roeck <linux@...ck-us.net>
Signed-off-by: Gabriel Krisman Bertazi <krisman@...labora.com>
Signed-off-by: Jan Kara <jack@...e.cz>
Signed-off-by: Chuck Lever <chuck.lever@...cle.com>
---
 samples/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/samples/Kconfig b/samples/Kconfig
index cecd311ff321..a98e89992a18 100644
--- a/samples/Kconfig
+++ b/samples/Kconfig
@@ -122,7 +122,7 @@ config SAMPLE_CONNECTOR
 
 config SAMPLE_FANOTIFY_ERROR
 	bool "Build fanotify error monitoring sample"
-	depends on FANOTIFY
+	depends on FANOTIFY && CC_CAN_LINK && HEADERS_INSTALL
 	help
 	  When enabled, this builds an example code that uses the
 	  FAN_FS_ERROR fanotify mechanism to monitor filesystem
-- 
2.45.2