linux-ext4 - Re: [PATCH 6/7] jbd2: correct comment jbd2_mark_journal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240730133755.lbu65hpxwxq6eo64@quack3>
Date: Tue, 30 Jul 2024 15:37:55 +0200
From: Jan Kara <jack@...e.cz>
To: Kemeng Shi <shikemeng@...weicloud.com>
Cc: tytso@....edu, jack@...e.com, linux-ext4@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 6/7] jbd2: correct comment jbd2_mark_journal_empty

On Tue 30-07-24 19:33:34, Kemeng Shi wrote:
> After jbd2_mark_journal_empty, journal log is supposed to be empty.
> 
> Signed-off-by: Kemeng Shi <shikemeng@...weicloud.com>

Looks good. Feel free to add:

Reviewed-by: Jan Kara <jack@...e.cz>

							Honza

> ---
>  fs/jbd2/journal.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c
> index f17d05bc61df..dc18b9f7c999 100644
> --- a/fs/jbd2/journal.c
> +++ b/fs/jbd2/journal.c
> @@ -1939,7 +1939,7 @@ static void jbd2_mark_journal_empty(journal_t *journal, blk_opf_t write_flags)
>  	if (had_fast_commit)
>  		jbd2_set_feature_fast_commit(journal);
>  
> -	/* Log is no longer empty */
> +	/* Log is empty */
>  	write_lock(&journal->j_state_lock);
>  	journal->j_flags |= JBD2_FLUSHED;
>  	write_unlock(&journal->j_state_lock);
> -- 
> 2.30.0
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR