linux-ext4 - Re: [linux-next:master] [fs] cdc4ad36a8: kernel_BUG_at

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e693ed7a-97bf-486b-84fb-f57e44a399b4@arm.com>
Date: Wed, 7 Aug 2024 08:38:23 +0100
From: Ryan Roberts <ryan.roberts@....com>
To: Matthew Wilcox <willy@...radead.org>,
 kernel test robot <oliver.sang@...el.com>,
 Christian Brauner <brauner@...nel.org>
Cc: oe-lkp@...ts.linux.dev, lkp@...el.com,
 Linux Memory Management List <linux-mm@...ck.org>,
 linux-fsdevel@...r.kernel.org, linux-block@...r.kernel.org,
 intel-gfx@...ts.freedesktop.org, linux-bcachefs@...r.kernel.org,
 ceph-devel@...r.kernel.org, ecryptfs@...r.kernel.org,
 linux-ext4@...r.kernel.org, linux-f2fs-devel@...ts.sourceforge.net,
 linux-um@...ts.infradead.org, linux-mtd@...ts.infradead.org,
 jfs-discussion@...ts.sourceforge.net, linux-nfs@...r.kernel.org,
 linux-nilfs@...r.kernel.org, ntfs3@...ts.linux.dev,
 ocfs2-devel@...ts.linux.dev, linux-karma-devel@...ts.sourceforge.net,
 devel@...ts.orangefs.org, reiserfs-devel@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [linux-next:master] [fs] cdc4ad36a8:
 kernel_BUG_at_include/linux/page-flags.h

On 07/08/2024 04:46, Matthew Wilcox wrote:
> On Tue, Aug 06, 2024 at 10:26:17PM +0800, kernel test robot wrote:
>> kernel test robot noticed "kernel_BUG_at_include/linux/page-flags.h" on:
>>
>> commit: cdc4ad36a871b7ac43fcc6b2891058d332ce60ce ("fs: Convert aops->write_begin to take a folio")
>> https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git master
>>
>> [test failed on linux-next/master 1e391b34f6aa043c7afa40a2103163a0ef06d179]
>>
>> in testcase: boot
> 
> This patch should fix it.
> 
> Christian, can you squash the fix in?
> 
> 
> diff --git a/mm/shmem.c b/mm/shmem.c
> index 7d28304aea0f..66ff87417090 100644
> --- a/mm/shmem.c
> +++ b/mm/shmem.c
> @@ -2904,7 +2904,8 @@ shmem_write_begin(struct file *file, struct address_space *mapping,
>  	if (ret)
>  		return ret;
>  
> -	if (folio_test_has_hwpoisoned(folio)) {
> +	if (folio_test_hwpoison(folio) ||
> +	    (folio_test_large(folio) && folio_test_has_hwpoisoned(folio))) {

Reviewed-by: Ryan Roberts <ryan.roberts@....com>
Tested-by: Ryan Roberts <ryan.roberts@....com>


>  		folio_unlock(folio);
>  		folio_put(folio);
>  		return -EIO;