linux-ext4 - [PATCH v3 00/12] ext4: simplify the counting and management of delalloc reserved blocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240813123452.2824659-1-yi.zhang@huaweicloud.com>
Date: Tue, 13 Aug 2024 20:34:40 +0800
From: Zhang Yi <yi.zhang@...weicloud.com>
To: linux-ext4@...r.kernel.org
Cc: linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	tytso@....edu,
	adilger.kernel@...ger.ca,
	jack@...e.cz,
	ritesh.list@...il.com,
	yi.zhang@...wei.com,
	yi.zhang@...weicloud.com,
	chengzhihao1@...wei.com,
	yukuai3@...wei.com
Subject: [PATCH v3 00/12] ext4: simplify the counting and management of delalloc reserved blocks

From: Zhang Yi <yi.zhang@...wei.com>

Changes since v2:
 - In patch 3, update the chang log as Jan suggested.
 - In patch 5 and 6, when moving reserved blocks count updating to
   ext4_es_insert_extent(), chang the condition for determining quota
   claim by passing allocation information instead of counting used
   reserved blocks as Jan suggested.
 - Add patch 9, drop an unused helper ext4_es_store_status().
 - Add patch 10, make extent status type exclusive, add assertion and
   commtents as Jan suggested.

Changes since v1:
 - Just rebase to v6.11-rc1.

This patch series is the part 3 prepartory changes of the buffered IO
iomap conversion, it simplify the counting and updating logic of
delalloc reserved blocks. I picked them out from my buffered IO iomap
conversion RFC series v4[1], and did some minor improvements of commit
messages. This series is based on 6.11-rc3, after it we could save a lot
of code.

Patch 1-3 simplify the delalloc extent management logic by changes to
always set EXT4_GET_BLOCKS_DELALLOC_RESERVE flag when allocating
preallocated blocks, and don't add EXTENT_STATUS_DELAYED flag to an
unwritten extent, which means ext4_es_is_delayed() is equal to
ext4_es_is_delonly().

Patch 4-6 simplify the reserved blocks updating logic by moves the
reserved blocks updating from ext4_{ind|ext}_map_blocks() to
ext4_es_insert_extent().

Patch 7-12 make extent status type exclusive and drop the unused code
(e.g. ext4_es_is_delonly()), update comments and do some cleanup.

[1] https://lore.kernel.org/linux-ext4/20240410142948.2817554-1-yi.zhang@huaweicloud.com/

Thanks,
Yi.

Zhang Yi (12):
  ext4: factor out ext4_map_create_blocks() to allocate new blocks
  ext4: optimize the EXT4_GET_BLOCKS_DELALLOC_RESERVE flag set
  ext4: don't set EXTENT_STATUS_DELAYED on allocated blocks
  ext4: let __revise_pending() return newly inserted pendings
  ext4: passing block allocation information to ext4_es_insert_extent()
  ext4: update delalloc data reserve spcae in ext4_es_insert_extent()
  ext4: drop ext4_es_delayed_clu()
  ext4: use ext4_map_query_blocks() in ext4_map_blocks()
  ext4: drop unused ext4_es_store_status()
  ext4: make extent status types exclusive
  ext4: drop ext4_es_is_delonly()
  ext4: drop all delonly descriptions

 fs/ext4/extents.c        |  42 +------
 fs/ext4/extents_status.c | 240 ++++++++++++++-------------------------
 fs/ext4/extents_status.h |  28 ++---
 fs/ext4/indirect.c       |   7 --
 fs/ext4/inode.c          | 201 ++++++++++++++------------------
 5 files changed, 189 insertions(+), 329 deletions(-)

-- 
2.39.2