linux-ext4 - Re: sort out the fallocate mode mess

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240821161156.GB865349@frogsfrogsfrogs>
Date: Wed, 21 Aug 2024 09:11:56 -0700
From: "Darrick J. Wong" <djwong@...nel.org>
To: Christoph Hellwig <hch@....de>
Cc: Christian Brauner <brauner@...nel.org>,
	Alexander Viro <viro@...iv.linux.org.uk>,
	Chandan Babu R <chandan.babu@...cle.com>,
	Jens Axboe <axboe@...nel.dk>, Jan Kara <jack@...e.cz>,
	Theodore Ts'o <tytso@....edu>, linux-block@...r.kernel.org,
	linux-fsdevel@...r.kernel.org, linux-xfs@...r.kernel.org,
	linux-ext4@...r.kernel.org
Subject: Re: sort out the fallocate mode mess

On Wed, Aug 21, 2024 at 08:30:26AM +0200, Christoph Hellwig wrote:
> Hi all,
> 
> I've recently been looking at the XFS fallocate implementation and got
> upset about the messing parsing of the mode argument, which mixes modes
> and an optional flag in a really confusing way.
> 
> This series tries to clean this up by better defining what is the
> operation mode and what is an optional flag, so that both the core
> code and file systems can use switch statements to switch on the mode.

For patches 4-6,
Acked-by: Darrick J. Wong <djwong@...nel.org>

(I'm not going to touch the NO_HIDE_STALE pony, I'll let you and tytso
mix it up over^W^W^W^Wdiscuss that...)

--D