linux-ext4 - Re: [PATCH 2/6] ext4: remove tracing for FALLOC_FL_NO_HIDE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240827145634.GR865349@frogsfrogsfrogs>
Date: Tue, 27 Aug 2024 07:56:34 -0700
From: "Darrick J. Wong" <djwong@...nel.org>
To: Christoph Hellwig <hch@....de>
Cc: Christian Brauner <brauner@...nel.org>,
	Alexander Viro <viro@...iv.linux.org.uk>,
	Chandan Babu R <chandan.babu@...cle.com>,
	Brian Foster <bfoster@...hat.com>, Jens Axboe <axboe@...nel.dk>,
	Jan Kara <jack@...e.cz>, Theodore Ts'o <tytso@....edu>,
	linux-block@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	linux-xfs@...r.kernel.org, linux-ext4@...r.kernel.org
Subject: Re: [PATCH 2/6] ext4: remove tracing for FALLOC_FL_NO_HIDE_STALE

On Tue, Aug 27, 2024 at 08:50:46AM +0200, Christoph Hellwig wrote:
> FALLOC_FL_NO_HIDE_STALE can't make it past vfs_fallocate (and if the
> flag does what the name implies that's a good thing as it would be
> highly dangerous).  Remove the dead tracing code for it.
> 
> Signed-off-by: Christoph Hellwig <hch@....de>
> ---
>  include/trace/events/ext4.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/include/trace/events/ext4.h b/include/trace/events/ext4.h
> index cc5e9b7b2b44e7..156908641e68f1 100644
> --- a/include/trace/events/ext4.h
> +++ b/include/trace/events/ext4.h
> @@ -91,7 +91,6 @@ TRACE_DEFINE_ENUM(ES_REFERENCED_B);
>  #define show_falloc_mode(mode) __print_flags(mode, "|",		\
>  	{ FALLOC_FL_KEEP_SIZE,		"KEEP_SIZE"},		\
>  	{ FALLOC_FL_PUNCH_HOLE,		"PUNCH_HOLE"},		\
> -	{ FALLOC_FL_NO_HIDE_STALE,	"NO_HIDE_STALE"},	\

If we're going to drop this flag that has never been accepted by any of
the fallocate implementations, then can we remove it from the uapi?

--D

>  	{ FALLOC_FL_COLLAPSE_RANGE,	"COLLAPSE_RANGE"},	\
>  	{ FALLOC_FL_ZERO_RANGE,		"ZERO_RANGE"})
>  
> -- 
> 2.43.0
> 
>