lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <87bk1aza62.fsf@gmail.com> Date: Fri, 30 Aug 2024 13:58:53 +0530 From: Ritesh Harjani (IBM) <ritesh.list@...il.com> To: Ojaswin Mujoo <ojaswin@...ux.ibm.com>, linux-ext4@...r.kernel.org, Theodore Ts'o <tytso@....edu> Cc: linux-kernel@...r.kernel.org, Kemeng Shi <shikemeng@...weicloud.com> Subject: Re: [PATCH v3 2/2] ext4: Convert EXT4_B2C(sbi->s_stripe) users to EXT4_NUM_B2C Ojaswin Mujoo <ojaswin@...ux.ibm.com> writes: > Although we have checks to make sure s_stripe is a multiple of cluster > size, in case we accidentally end up with a scenario where this is not > the case, use EXT4_NUM_B2C() so that we don't end up with unexpected > cases where EXT4_B2C(stripe) becomes 0. > > Also make the is_stripe_aligned check in regular_allocator a bit more > robust while we are at it. This should ideally have no functional change > unless we have a bug somewhere causing (stripe % cluster_size != 0) > > Reviewed-by: Kemeng Shi <shikemeng@...weicloud.com> > Signed-off-by: Ojaswin Mujoo <ojaswin@...ux.ibm.com> Thanks for addressing the review comment. LGTM. Please feel free to add - Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@...il.com>
Powered by blists - more mailing lists