linux-ext4 - Re: [PATCH v3 09/12] ext4: drop unused ext4_es_store

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240904102551.vgwlivosmk6ysh6j@quack3>
Date: Wed, 4 Sep 2024 12:25:51 +0200
From: Jan Kara <jack@...e.cz>
To: Zhang Yi <yi.zhang@...weicloud.com>
Cc: linux-ext4@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org, tytso@....edu,
	adilger.kernel@...ger.ca, jack@...e.cz, ritesh.list@...il.com,
	yi.zhang@...wei.com, chengzhihao1@...wei.com, yukuai3@...wei.com
Subject: Re: [PATCH v3 09/12] ext4: drop unused ext4_es_store_status()

On Tue 13-08-24 20:34:49, Zhang Yi wrote:
> From: Zhang Yi <yi.zhang@...wei.com>
> 
> The helper ext4_es_store_status() is unused now, just drop it.
> 
> Signed-off-by: Zhang Yi <yi.zhang@...wei.com>

Yes. Feel free to add:

Reviewed-by: Jan Kara <jack@...e.cz>

									Honza

> ---
>  fs/ext4/extents_status.h | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/fs/ext4/extents_status.h b/fs/ext4/extents_status.h
> index 47b3b55a852c..3ca40f018994 100644
> --- a/fs/ext4/extents_status.h
> +++ b/fs/ext4/extents_status.h
> @@ -224,13 +224,6 @@ static inline void ext4_es_store_pblock(struct extent_status *es,
>  	es->es_pblk = block;
>  }
>  
> -static inline void ext4_es_store_status(struct extent_status *es,
> -					unsigned int status)
> -{
> -	es->es_pblk = (((ext4_fsblk_t)status << ES_SHIFT) & ES_MASK) |
> -		      (es->es_pblk & ~ES_MASK);
> -}
> -
>  static inline void ext4_es_store_pblock_status(struct extent_status *es,
>  					       ext4_fsblk_t pb,
>  					       unsigned int status)
> -- 
> 2.39.2
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR