lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <0d8ffff7-6b51-16fe-bf11-a6f126a81c58@huaweicloud.com> Date: Wed, 4 Sep 2024 19:43:44 +0800 From: Zhang Yi <yi.zhang@...weicloud.com> To: Jan Kara <jack@...e.cz> Cc: linux-ext4@...r.kernel.org, linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org, tytso@....edu, adilger.kernel@...ger.ca, ritesh.list@...il.com, yi.zhang@...wei.com, chengzhihao1@...wei.com, yukuai3@...wei.com Subject: Re: [PATCH v3 05/12] ext4: passing block allocation information to ext4_es_insert_extent() On 2024/9/4 18:21, Jan Kara wrote: > On Tue 13-08-24 20:34:45, Zhang Yi wrote: >> From: Zhang Yi <yi.zhang@...wei.com> >> >> Just pass the block allocation flag to ext4_es_insert_extent() when we >> replacing a current extent after an actually block allocation or extent >> status conversion, this flag will be used by later changes. >> >> Suggested-by: Jan Kara <jack@...e.cz> >> Signed-off-by: Zhang Yi <yi.zhang@...wei.com> > > Looks good. Just one suggestion below. With that feel free to add: > > Reviewed-by: Jan Kara <jack@...e.cz> > >> @@ -848,7 +848,7 @@ static int __es_insert_extent(struct inode *inode, struct extent_status *newes, >> */ >> void ext4_es_insert_extent(struct inode *inode, ext4_lblk_t lblk, >> ext4_lblk_t len, ext4_fsblk_t pblk, >> - unsigned int status) >> + unsigned int status, int flags) > > Since you pass flags to ext4_es_insert_extent() only from one place, let's > not pretend these are always full mapping flags and just make this new > argument: > > bool delalloc_reserve_used > > and from ext4_map_blocks_create() you can pass flags & > EXT4_GET_BLOCKS_DELALLOC_RESERVE. > Sure, it's a better idea than passing full mapping flags, thanks for your suggestion, but since I've noticed that Ted had already picked this series into his dev branch, I can send another patch to do this. Thanks a lot for reviewing this series again! Yi.
Powered by blists - more mailing lists