linux-ext4 - Re: [PATCH v2] ext4: clear EXT4_GROUP_INFO_WAS_TRIMMED

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <172554793830.1268668.15796910397193830249.b4-ty@mit.edu>
Date: Thu,  5 Sep 2024 10:53:47 -0400
From: "Theodore Ts'o" <tytso@....edu>
To: jack@...e.cz, yangerkun <yangerkun@...weicloud.com>
Cc: "Theodore Ts'o" <tytso@....edu>, linux-ext4@...r.kernel.org,
        yangerkun@...wei.com
Subject: Re: [PATCH v2] ext4: clear EXT4_GROUP_INFO_WAS_TRIMMED_BIT even mount with discard


On Sat, 17 Aug 2024 16:55:10 +0800, yangerkun wrote:
> Commit 3d56b8d2c74c ("ext4: Speed up FITRIM by recording flags in
> ext4_group_info") speed up fstrim by skipping trim trimmed group. We
> also has the chance to clear trimmed once there exists some block free
> for this group(mount without discard), and the next trim for this group
> will work well too.
> 
> For mount with discard, we will issue dicard when we free blocks, so
> leave trimmed flag keep alive to skip useless trim trigger from
> userspace seems reasonable. But for some case like ext4 build on
> dm-thinpool(ext4 blocksize 4K, pool blocksize 128K), discard from ext4
> maybe unaligned for dm thinpool, and thinpool will just finish this
> discard(see process_discard_bio when begein equals to end) without
> actually process discard. For this case, trim from userspace can really
> help us to free some thinpool block.
> 
> [...]

Applied, thanks!

[1/1] ext4: clear EXT4_GROUP_INFO_WAS_TRIMMED_BIT even mount with discard
      commit: 20cee68f5b44fdc2942d20f3172a262ec247b117

Best regards,
-- 
Theodore Ts'o <tytso@....edu>