linux-ext4 - Re: [syzbot] [keyrings?] [lsm?] [ext4?] possible deadlock in keyring

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <tencent_AC4A33669E2C1B724B1C1BCA2552BA67BB08@qq.com>
Date: Sun, 22 Sep 2024 19:28:13 +0800
From: Edward Adam Davis <eadavis@...com>
To: syzbot+1b2d1134e0b675176a15@...kaller.appspotmail.com
Cc: dhowells@...hat.com,
	jarkko@...nel.org,
	jmorris@...ei.org,
	keyrings@...r.kernel.org,
	linux-ext4@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	linux-security-module@...r.kernel.org,
	paul@...l-moore.com,
	serge@...lyn.com,
	syzkaller-bugs@...glegroups.com
Subject: Re: [syzbot] [keyrings?] [lsm?] [ext4?] possible deadlock in keyring_clear (2)

Use GFP_NOFS

#syz test

diff --git a/lib/assoc_array.c b/lib/assoc_array.c
index 388e656ac974..b6fd9e909b79 100644
--- a/lib/assoc_array.c
+++ b/lib/assoc_array.c
@@ -977,7 +977,7 @@ struct assoc_array_edit *assoc_array_insert(struct assoc_array *array,
 	 */
 	BUG_ON(assoc_array_ptr_is_meta(object));
 
-	edit = kzalloc(sizeof(struct assoc_array_edit), GFP_KERNEL);
+	edit = kzalloc(sizeof(struct assoc_array_edit), GFP_NOFS);
 	if (!edit)
 		return ERR_PTR(-ENOMEM);
 	edit->array = array;