lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <66ef6c2bb7f9_edc02946b@dwillia2-mobl3.amr.corp.intel.com.notmuch> Date: Sun, 22 Sep 2024 03:00:27 +0200 From: Dan Williams <dan.j.williams@...el.com> To: Alistair Popple <apopple@...dia.com>, <dan.j.williams@...el.com>, <linux-mm@...ck.org> CC: Alistair Popple <apopple@...dia.com>, <vishal.l.verma@...el.com>, <dave.jiang@...el.com>, <logang@...tatee.com>, <bhelgaas@...gle.com>, <jack@...e.cz>, <jgg@...pe.ca>, <catalin.marinas@....com>, <will@...nel.org>, <mpe@...erman.id.au>, <npiggin@...il.com>, <dave.hansen@...ux.intel.com>, <ira.weiny@...el.com>, <willy@...radead.org>, <djwong@...nel.org>, <tytso@....edu>, <linmiaohe@...wei.com>, <david@...hat.com>, <peterx@...hat.com>, <linux-doc@...r.kernel.org>, <linux-kernel@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>, <linuxppc-dev@...ts.ozlabs.org>, <nvdimm@...ts.linux.dev>, <linux-cxl@...r.kernel.org>, <linux-fsdevel@...r.kernel.org>, <linux-ext4@...r.kernel.org>, <linux-xfs@...r.kernel.org>, <jhubbard@...dia.com>, <hch@....de>, <david@...morbit.com>, Jason Gunthorpe <jgg@...dia.com> Subject: Re: [PATCH 01/12] mm/gup.c: Remove redundant check for PCI P2PDMA page Alistair Popple wrote: > PCI P2PDMA pages are not mapped with pXX_devmap PTEs therefore the > check in __gup_device_huge() is redundant. Remove it > > Signed-off-by: Alistair Popple <apopple@...dia.com> > Reviewed-by: Jason Gunthorpe <jgg@...dia.com> > Acked-by: David Hildenbrand <david@...hat.com> > --- > mm/gup.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/mm/gup.c b/mm/gup.c > index d19884e..5d2fc9a 100644 > --- a/mm/gup.c > +++ b/mm/gup.c > @@ -2954,11 +2954,6 @@ static int gup_fast_devmap_leaf(unsigned long pfn, unsigned long addr, > break; > } > > - if (!(flags & FOLL_PCI_P2PDMA) && is_pci_p2pdma_page(page)) { > - gup_fast_undo_dev_pagemap(nr, nr_start, flags, pages); > - break; > - } > - Looks good. Reviewed-by: Dan Wiliams <dan.j.williams@...el.com>
Powered by blists - more mailing lists