lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <cf895072-43cf-412c-bced-8268498ad13e@web.de> Date: Wed, 25 Sep 2024 21:54:18 +0200 From: Markus Elfring <Markus.Elfring@....de> To: linux-ext4@...r.kernel.org, Andreas Dilger <adilger.kernel@...ger.ca>, Jan Kara <jack@...e.cz>, Matthew Bobrowski <mbobrowski@...browski.org>, Ritesh Harjani <riteshh@...ux.ibm.com>, Theodore Ts'o <tytso@....edu> Cc: LKML <linux-kernel@...r.kernel.org>, kernel-janitors@...r.kernel.org Subject: [PATCH] ext4: Call ext4_journal_stop(handle) only once in ext4_dio_write_iter() From: Markus Elfring <elfring@...rs.sourceforge.net> Date: Wed, 25 Sep 2024 21:47:39 +0200 An ext4_journal_stop(handle) call was immediately used after a return value check for a ext4_orphan_add() call in this function implementation. Thus call such a function only once instead directly before the check. This issue was transformed by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net> --- fs/ext4/file.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/fs/ext4/file.c b/fs/ext4/file.c index f14aed14b9cf..23005f1345a8 100644 --- a/fs/ext4/file.c +++ b/fs/ext4/file.c @@ -564,12 +564,9 @@ static ssize_t ext4_dio_write_iter(struct kiocb *iocb, struct iov_iter *from) } ret = ext4_orphan_add(handle, inode); - if (ret) { - ext4_journal_stop(handle); - goto out; - } - ext4_journal_stop(handle); + if (ret) + goto out; } if (ilock_shared && !unwritten) -- 2.46.1
Powered by blists - more mailing lists