linux-ext4 - Re: [PATCH v2] fs: ext4: support relative path for `journal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240925020913.GH3550746@ZenIV>
Date: Wed, 25 Sep 2024 03:09:13 +0100
From: Al Viro <viro@...iv.linux.org.uk>
To: Hongbo Li <lihongbo22@...wei.com>
Cc: tytso@....edu, adilger.kernel@...ger.ca, brauner@...nel.org,
	jack@...e.cz, linux-ext4@...r.kernel.org,
	linux-fsdevel@...r.kernel.org, chris.zjh@...wei.com
Subject: Re: [PATCH v2] fs: ext4: support relative path for `journal_path` in
 mount option.

On Wed, Sep 25, 2024 at 09:56:24AM +0800, Hongbo Li wrote:
> @@ -156,6 +156,9 @@ int fs_lookup_param(struct fs_context *fc,
>  		f = getname_kernel(param->string);
>  		if (IS_ERR(f))
>  			return PTR_ERR(f);
> +		/* for relative path */
> +		if (f->name[0] != '/')
> +			param->dirfd = AT_FDCWD;

Will need to dig around for some context, but this bit definitely makes
no sense - dirfd is completely ignored for absolute pathnames, so making
that store conditional is pointless.