lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20240926125244.5l2ajllkdfcbpko5@quack3> Date: Thu, 26 Sep 2024 14:52:44 +0200 From: Jan Kara <jack@...e.cz> To: Ye Bin <yebin@...weicloud.com> Cc: tytso@....edu, adilger.kernel@...ger.ca, linux-ext4@...r.kernel.org, jack@...e.cz, zhangxiaoxu5@...wei.com Subject: Re: [PATCH 1/5] jbd2: remove redundant judgments for check v1 checksum On Wed 18-09-24 19:36:00, Ye Bin wrote: > From: Ye Bin <yebin10@...wei.com> > > 'need_check_commit_time' is only used by v2/v3 checksum, so there isn't > need to add 'need_check_commit_time' judegement for v1 checksum logic. > > Signed-off-by: Ye Bin <yebin10@...wei.com> Looks good. Feel free to add: Reviewed-by: Jan Kara <jack@...e.cz> Honza > --- > fs/jbd2/recovery.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/fs/jbd2/recovery.c b/fs/jbd2/recovery.c > index 667f67342c52..5efbca6a98c4 100644 > --- a/fs/jbd2/recovery.c > +++ b/fs/jbd2/recovery.c > @@ -619,7 +619,6 @@ static int do_one_pass(journal_t *journal, > if (pass != PASS_REPLAY) { > if (pass == PASS_SCAN && > jbd2_has_feature_checksum(journal) && > - !need_check_commit_time && > !info->end_transaction) { > if (calc_chksums(journal, bh, > &next_log_block, > -- > 2.31.1 > -- Jan Kara <jack@...e.com> SUSE Labs, CR
Powered by blists - more mailing lists