linux-ext4 - Re: [PATCH v2] ext4: fix off by one issue in alloc_flex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fbe9ed47-b3cc-4c51-8d25-f44838327f89@redhat.com>
Date: Fri, 27 Sep 2024 09:14:52 -0500
From: Eric Sandeen <sandeen@...hat.com>
To: libaokun@...weicloud.com, linux-ext4@...r.kernel.org
Cc: tytso@....edu, adilger.kernel@...ger.ca, jack@...e.cz,
 linux-kernel@...r.kernel.org, yi.zhang@...wei.com, yangerkun@...wei.com,
 Baokun Li <libaokun1@...wei.com>,
 Wesley Hershberger <wesley.hershberger@...onical.com>,
 Stéphane Graber <stgraber@...raber.org>,
 Alexander Mikhalitsyn <aleksandr.mikhalitsyn@...onical.com>,
 stable@...r.kernel.org
Subject: Re: [PATCH v2] ext4: fix off by one issue in alloc_flex_gd()

On 9/27/24 8:33 AM, libaokun@...weicloud.com wrote:
> From: Baokun Li <libaokun1@...wei.com>
> 

...

> Delete the problematic plus 1 to fix the issue, and add a WARN_ON_ONCE()
> to prevent the issue from happening again.
> 
> Reported-by: Wesley Hershberger <wesley.hershberger@...onical.com>
> Closes: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/2081231
> Reported-by: Stéphane Graber <stgraber@...raber.org>
> Closes: https://lore.kernel.org/all/20240925143325.518508-1-aleksandr.mikhalitsyn@canonical.com/
> Tested-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@...onical.com>
> Tested-by: Eric Sandeen <sandeen@...hat.com>

The patch has changed a little since I tested, but it still passes my testcase
(as expected, no WARN ON etc) so looks good from that POV, thanks!
-Eric