linux-ext4 - Re: [ext4?] [ocfs2?] WARNING in jbd2_journal_update_sb_log

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240930090009.174420-1-lizhi.xu@windriver.com>
Date: Mon, 30 Sep 2024 17:00:09 +0800
From: Lizhi Xu <lizhi.xu@...driver.com>
To: <syzbot+96ee12698391289383dd@...kaller.appspotmail.com>
CC: <jack@...e.com>, <jlbec@...lplan.org>, <joseph.qi@...ux.alibaba.com>,
        <linux-ext4@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <mark@...heh.com>, <ocfs2-devel@...ts.linux.dev>,
        <syzkaller-bugs@...glegroups.com>, <tytso@....edu>
Subject: Re: [ext4?] [ocfs2?] WARNING in jbd2_journal_update_sb_log_tail

The s_sequence value of journal superblock loaded from disk is 4294967295,
is it too large?

#syz test

diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c
index 97f487c3d8fc..563c4af533ac 100644
--- a/fs/jbd2/journal.c
+++ b/fs/jbd2/journal.c
@@ -1397,6 +1397,12 @@ static int journal_check_superblock(journal_t *journal)
 		}
 	}
 
+	if (sb->s_sequence == U32_MAX) {
+		pr_err("JBD2: Load a too big s_sequence: %u, %s\n", 
+			sb->s_sequence, __func__);
+		return err;
+	}
+
 	return 0;
 }