linux-ext4 - Re: [PATCH] ext4: show the default enabled prefetch_block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241008130528.snt2iflir7pm5co6@quack3>
Date: Tue, 8 Oct 2024 15:05:28 +0200
From: Jan Kara <jack@...e.cz>
To: libaokun@...weicloud.com
Cc: linux-ext4@...r.kernel.org, tytso@....edu, adilger.kernel@...ger.ca,
	jack@...e.cz, linux-kernel@...r.kernel.org, yi.zhang@...wei.com,
	yangerkun@...wei.com, Baokun Li <libaokun1@...wei.com>
Subject: Re: [PATCH] ext4: show the default enabled prefetch_block_bitmaps
 option

On Tue 08-10-24 20:01:34, libaokun@...weicloud.com wrote:
> From: Baokun Li <libaokun1@...wei.com>
> 
> After commit 21175ca434c5 ("ext4: make prefetch_block_bitmaps default"),
> we enable 'prefetch_block_bitmaps' by default, but this is not shown in
> the '/proc/fs/ext4/sdx/options' procfs interface.
> 
> This makes it impossible to distinguish whether the feature is enabled by
> default or not, so 'prefetch_block_bitmaps' is shown in the 'options'
> procfs interface when prefetch_block_bitmaps is enabled by default.
> 
> This makes it easy to notice changes to the default mount options between
> versions through the '/proc/fs/ext4/sdx/options' procfs interface.
> 
> Signed-off-by: Baokun Li <libaokun1@...wei.com>

Looks good. Feel free to add:

Reviewed-by: Jan Kara <jack@...e.cz>

								Honza

> ---
>  fs/ext4/super.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index b77acba4a719..c88a47639e9c 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -3030,6 +3030,9 @@ static int _ext4_show_options(struct seq_file *seq, struct super_block *sb,
>  		SEQ_OPTS_PUTS("mb_optimize_scan=1");
>  	}
>  
> +	if (!test_opt(sb, NO_PREFETCH_BLOCK_BITMAPS))
> +		SEQ_OPTS_PUTS("prefetch_block_bitmaps");
> +
>  	ext4_show_quota_options(seq, sb);
>  	return 0;
>  }
> -- 
> 2.31.1
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR