linux-ext4 - [PATCH v2] ext4: inode: Delete braces for single statements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20241014140654.69613-1-bretznic@gmail.com>
Date: Mon, 14 Oct 2024 07:06:54 -0700
From: Nicolas Bretz <bretznic@...il.com>
To: tytso@....edu
Cc: linux-ext4@...r.kernel.org,
	Nicolas Bretz <bretznic@...il.com>
Subject: [PATCH v2] ext4: inode: Delete braces for single statements

checkpatch.pl warnings - braces are not necessary

Removed trailing whitespaces introduced in v1

Signed-off-by: Nicolas Bretz <bretznic@...il.com>
---
 fs/ext4/inode.c | 15 +++++++--------
 1 file changed, 7 insertions(+), 8 deletions(-)

diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index 03c2253005f0..1c1c1ccc8a0c 100644
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -440,11 +440,11 @@ static void ext4_map_blocks_es_recheck(handle_t *handle,
 	 * could be converted.
 	 */
 	down_read(&EXT4_I(inode)->i_data_sem);
-	if (ext4_test_inode_flag(inode, EXT4_INODE_EXTENTS)) {
+	if (ext4_test_inode_flag(inode, EXT4_INODE_EXTENTS))
 		retval = ext4_ext_map_blocks(handle, inode, map, 0);
-	} else {
+	else
 		retval = ext4_ind_map_blocks(handle, inode, map, 0);
-	}
+
 	up_read((&EXT4_I(inode)->i_data_sem));
 
 	/*
@@ -453,7 +453,7 @@ static void ext4_map_blocks_es_recheck(handle_t *handle,
 	 */
 	if (es_map->m_lblk != map->m_lblk ||
 	    es_map->m_flags != map->m_flags ||
-	    es_map->m_pblk != map->m_pblk) {
+	    es_map->m_pblk != map->m_pblk)
 		printk("ES cache assertion failed for inode: %lu "
 		       "es_cached ex [%d/%d/%llu/%x] != "
 		       "found ex [%d/%d/%llu/%x] retval %d flags %x\n",
@@ -461,7 +461,6 @@ static void ext4_map_blocks_es_recheck(handle_t *handle,
 		       es_map->m_pblk, es_map->m_flags, map->m_lblk,
 		       map->m_len, map->m_pblk, map->m_flags,
 		       retval, flags);
-	}
 }
 #endif /* ES_AGGRESSIVE_TEST */
 
@@ -547,11 +546,11 @@ int ext4_map_blocks(handle_t *handle, struct inode *inode,
 	 * file system block.
 	 */
 	down_read(&EXT4_I(inode)->i_data_sem);
-	if (ext4_test_inode_flag(inode, EXT4_INODE_EXTENTS)) {
+	if (ext4_test_inode_flag(inode, EXT4_INODE_EXTENTS))
 		retval = ext4_ext_map_blocks(handle, inode, map, 0);
-	} else {
+	else
 		retval = ext4_ind_map_blocks(handle, inode, map, 0);
-	}
+
 	if (retval > 0) {
 		unsigned int status;
 
-- 
2.39.5