linux-ext4 - Re: [PATCH] ext4/032: add a new testcase in online resize tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d137f247-97c0-4a42-b4ed-ae84ad8e727a@huawei.com>
Date: Sat, 9 Nov 2024 11:32:03 +0800
From: Baokun Li <libaokun1@...wei.com>
To: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@...onical.com>,
	<fstests@...r.kernel.org>
CC: <linux-ext4@...r.kernel.org>, <jack@...e.cz>, <tytso@....edu>, Yang Erkun
	<yangerkun@...wei.com>
Subject: Re: [PATCH] ext4/032: add a new testcase in online resize tests

Hi Alexander,

Thanks for the patch.

On 2024/11/8 21:48, Alexander Mikhalitsyn wrote:
> Add a new testcase for [1] commit in ext4 online resize testsuite.
>
> Link: https://lore.kernel.org/linux-ext4/20240927133329.1015041-1-libaokun@huaweicloud.com [1]
> Signed-off-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@...onical.com>
> ---
>   tests/ext4/032 | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/tests/ext4/032 b/tests/ext4/032
> index 6bc3b61b..77d592f4 100755
> --- a/tests/ext4/032
> +++ b/tests/ext4/032
> @@ -97,6 +97,10 @@ mkdir -p $IMG_MNT || _fail "cannot create loopback mount point"
>   # Check if online resizing with bigalloc is supported by the kernel
>   ext4_online_resize 4096 8192 1
>   
> +_fixed_by_kernel_commit 6121258c2b33 \
> +	"ext4: fix off by one issue in alloc_flex_gd()"
> +ext4_online_resize $(c2b 6400) $(c2b 786432)
> +
I think this test would be better placed in the loop below. Then add some
comments describing the scenario being tested.

There are two current scenarios for off by one:
  * The above test is to expand from the first block group of a flex_bg to
    the next flex_bg;
  * Another scenario is to expand from the first block group of a flex_bg
    to the last block group of this flex_bg. For example,
      `ext4_online_resize $(c2b 6400) $(c2b 524288)`

In addition, we need to modify the tests/ext4/032.out or the use cases
will fail due to inconsistent output.


Regards,
Baokun
>   ## We perform resizing to various multiples of block group sizes to
>   ## ensure that we cover maximum edge cases in the kernel code.
>   for CLUSTER_SIZ in 4096 16384 65536; do