lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20241112075134.GE1458936@google.com> Date: Tue, 12 Nov 2024 16:51:34 +0900 From: Sergey Senozhatsky <senozhatsky@...omium.org> To: Theodore Ts'o <tytso@....edu>, Andreas Dilger <adilger.kernel@...ger.ca> Cc: linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org, Sergey Senozhatsky <senozhatsky@...omium.org> Subject: Re: ext4: possible circular locking dependency at ext4_xattr_inode_create A silly typo [...] > diff --git a/fs/ext4/xattr.c b/fs/ext4/xattr.c > index 7647e9f6e190..db3c68fbbadf 100644 > --- a/fs/ext4/xattr.c > +++ b/fs/ext4/xattr.c > @@ -1511,7 +1511,7 @@ static struct inode *ext4_xattr_inode_create(handle_t *handle, > */ > dquot_free_inode(ea_inode); > dquot_drop(ea_inode); > - inode_lock(ea_inode); > + inode_lock_nested(inode, I_MUTEX_XATTR); ^^^ ea_inode, of course. --- diff --git a/fs/ext4/xattr.c b/fs/ext4/xattr.c index 7647e9f6e190..db3c68fbbadf 100644 --- a/fs/ext4/xattr.c +++ b/fs/ext4/xattr.c @@ -1511,7 +1511,7 @@ static struct inode *ext4_xattr_inode_create(handle_t *handle, */ dquot_free_inode(ea_inode); dquot_drop(ea_inode); - inode_lock(ea_inode); + inode_lock_nested(ea_inode, I_MUTEX_XATTR); ea_inode->i_flags |= S_NOQUOTA; inode_unlock(ea_inode); }
Powered by blists - more mailing lists