linux-ext4 - Re: [PATCH v8 01/19] fs: get rid of __FMODE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241118181434.iwsu2yqlkjyw4wkw@quack3>
Date: Mon, 18 Nov 2024 19:14:34 +0100
From: Jan Kara <jack@...e.cz>
To: Josef Bacik <josef@...icpanda.com>
Cc: kernel-team@...com, linux-fsdevel@...r.kernel.org, jack@...e.cz,
	amir73il@...il.com, brauner@...nel.org,
	torvalds@...ux-foundation.org, viro@...iv.linux.org.uk,
	linux-xfs@...r.kernel.org, linux-btrfs@...r.kernel.org,
	linux-mm@...ck.org, linux-ext4@...r.kernel.org
Subject: Re: [PATCH v8 01/19] fs: get rid of __FMODE_NONOTIFY kludge

On Fri 15-11-24 10:30:14, Josef Bacik wrote:
> From: Al Viro <viro@...iv.linux.org.uk>
> 
> All it takes to get rid of the __FMODE_NONOTIFY kludge is switching
> fanotify from anon_inode_getfd() to anon_inode_getfile_fmode() and adding
> a dentry_open_fmode() helper to be used by fanotify on the other path.
    ^^^ this ended up being dentry_open_nonotify()

> That's it - no more weird shit in OPEN_FMODE(), etc.
> 
> Suggested-by: Al Viro <viro@...iv.linux.org.uk>
> Link: https://lore.kernel.org/linux-fsdevel/20241113043003.GH3387508@ZenIV/
> Signed-off-by: Amir Goldstein <amir73il@...il.com>

...

> @@ -3706,11 +3708,9 @@ struct ctl_table;
>  int __init list_bdev_fs_names(char *buf, size_t size);
>  
>  #define __FMODE_EXEC		((__force int) FMODE_EXEC)
> -#define __FMODE_NONOTIFY	((__force int) FMODE_NONOTIFY)
>  
>  #define ACC_MODE(x) ("\004\002\006\006"[(x)&O_ACCMODE])
> -#define OPEN_FMODE(flag) ((__force fmode_t)(((flag + 1) & O_ACCMODE) | \
> -					    (flag & __FMODE_NONOTIFY)))
> +#define OPEN_FMODE(flag) ((__force fmode_t)(((flag + 1) & O_ACCMODE)))
					       ^^^ one more level of braces
than necessary now

Otherwise looks good to me. Don't need to resend just because of this, I
can fix this up if there's nothing else.

								Honza
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR