[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20241127005403.GS9438@frogsfrogsfrogs>
Date: Tue, 26 Nov 2024 16:54:03 -0800
From: "Darrick J. Wong" <djwong@...nel.org>
To: Nirjhar Roy <nirjhar@...ux.ibm.com>
Cc: fstests@...r.kernel.org, linux-ext4@...r.kernel.org,
linux-xfs@...r.kernel.org, ritesh.list@...il.com,
ojaswin@...ux.ibm.com, zlang@...nel.org
Subject: Re: [PATCH v4 2/3] common/rc: Add a new _require_scratch_extsize
helper function
On Tue, Nov 26, 2024 at 11:24:07AM +0530, Nirjhar Roy wrote:
> _require_scratch_extsize helper function will be used in the
> the next patch to make the test run only on filesystems with
> extsize support.
>
> Reviewed-by: Ojaswin Mujoo <ojaswin@...ux.ibm.com>
> Signed-off-by: Nirjhar Roy <nirjhar@...ux.ibm.com>
Looks good to me now,
Reviewed-by: "Darrick J. Wong" <djwong@...nel.org>
--D
> ---
> common/rc | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
> diff --git a/common/rc b/common/rc
> index f94bee5e..e6c6047d 100644
> --- a/common/rc
> +++ b/common/rc
> @@ -48,6 +48,23 @@ _test_fsxattr_xflag()
> grep -q "fsxattr.xflags.*\[.*$2.*\]" <($XFS_IO_PROG -c "stat -v" "$1")
> }
>
> +# This test requires extsize support on the filesystem
> +_require_scratch_extsize()
> +{
> + _require_scratch
> + _require_xfs_io_command "extsize"
> + _scratch_mkfs > /dev/null
> + _scratch_mount
> + local filename=$SCRATCH_MNT/$RANDOM
> + local blksz=$(_get_block_size $SCRATCH_MNT)
> + local extsz=$(( blksz*2 ))
> + local res=$($XFS_IO_PROG -c "open -f $filename" -c "extsize $extsz" \
> + -c "extsize")
> + _scratch_unmount
> + grep -q "\[$extsz\] $filename" <(echo $res) || \
> + _notrun "this test requires extsize support on the filesystem"
> +}
> +
> # Write a byte into a range of a file
> _pwrite_byte() {
> local pattern="$1"
> --
> 2.43.5
>
>
Powered by blists - more mailing lists