lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20241203144041.bygbhwhootsyyhsu@quack3> Date: Tue, 3 Dec 2024 15:40:41 +0100 From: Jan Kara <jack@...e.cz> To: Zhang Yi <yi.zhang@...weicloud.com> Cc: linux-ext4@...r.kernel.org, linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org, tytso@....edu, adilger.kernel@...ger.ca, jack@...e.cz, yi.zhang@...wei.com, chengzhihao1@...wei.com, yukuai3@...wei.com, yangerkun@...wei.com Subject: Re: [PATCH 1/2] jbd2: increase IO priority for writing revoke records On Tue 03-12-24 09:44:06, Zhang Yi wrote: > From: Zhang Yi <yi.zhang@...wei.com> > > Commit '6a3afb6ac6df ("jbd2: increase the journal IO's priority")' > increases the priority of journal I/O by marking I/O with the > JBD2_JOURNAL_REQ_FLAGS. However, that commit missed the revoke buffers, > so also addresses that kind of I/Os. > > Fixes: 6a3afb6ac6df ("jbd2: increase the journal IO's priority") > Signed-off-by: Zhang Yi <yi.zhang@...wei.com> Looks good. Feel free to add: Reviewed-by: Jan Kara <jack@...e.cz> Honza > --- > fs/jbd2/revoke.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/jbd2/revoke.c b/fs/jbd2/revoke.c > index 4556e4689024..ce63d5fde9c3 100644 > --- a/fs/jbd2/revoke.c > +++ b/fs/jbd2/revoke.c > @@ -654,7 +654,7 @@ static void flush_descriptor(journal_t *journal, > set_buffer_jwrite(descriptor); > BUFFER_TRACE(descriptor, "write"); > set_buffer_dirty(descriptor); > - write_dirty_buffer(descriptor, REQ_SYNC); > + write_dirty_buffer(descriptor, JBD2_JOURNAL_REQ_FLAGS); > } > #endif > > -- > 2.46.1 > -- Jan Kara <jack@...e.com> SUSE Labs, CR
Powered by blists - more mailing lists