lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20241204115814.5yqjont7ugtovc5g@quack3> Date: Wed, 4 Dec 2024 12:58:14 +0100 From: Jan Kara <jack@...e.cz> To: Zhang Yi <yi.zhang@...weicloud.com> Cc: linux-ext4@...r.kernel.org, linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org, tytso@....edu, adilger.kernel@...ger.ca, jack@...e.cz, ritesh.list@...il.com, hch@...radead.org, djwong@...nel.org, david@...morbit.com, zokeefe@...gle.com, yi.zhang@...wei.com, chengzhihao1@...wei.com, yukuai3@...wei.com, yangerkun@...wei.com Subject: Re: [PATCH 06/27] ext4: refactor ext4_collapse_range() On Tue 22-10-24 19:10:37, Zhang Yi wrote: > From: Zhang Yi <yi.zhang@...wei.com> > > Simplify ext4_collapse_range() and align its code style with that of > ext4_zero_range() and ext4_punch_hole(). Refactor it by: a) renaming > variables, b) removing redundant input parameter checks and moving > the remaining checks under i_rwsem in preparation for future > refactoring, and c) renaming the three stale error tags. > > Signed-off-by: Zhang Yi <yi.zhang@...wei.com> Looks good. Feel free to add: Reviewed-by: Jan Kara <jack@...e.cz> Just one nit below: > -out_stop: > +out_handle: > ext4_journal_stop(handle); > -out_mmap: > +out_invalidate_lock: > filemap_invalidate_unlock(mapping); > -out_mutex: > +out: > inode_unlock(inode); > return ret; > } Again, I think "out_inode_lock" would be a better name than just "out". Honza -- Jan Kara <jack@...e.com> SUSE Labs, CR
Powered by blists - more mailing lists