linux-ext4 - Re: [PATCH 1/4] generic/363: remove _supported

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z1g-3jUKnObTqjWj@bfoster>
Date: Tue, 10 Dec 2024 08:15:10 -0500
From: Brian Foster <bfoster@...hat.com>
To: Christoph Hellwig <hch@....de>
Cc: Zorro Lang <zlang@...nel.org>, fstests@...r.kernel.org,
	linux-ext4@...r.kernel.org
Subject: Re: [PATCH 1/4] generic/363: remove _supported_fs xfs

On Tue, Dec 10, 2024 at 07:58:25AM +0100, Christoph Hellwig wrote:
> Run this test for all file systems.  Just because they are broken doesn't
> mean that zeroing should not be tested.
> 
> Signed-off-by: Christoph Hellwig <hch@....de>
> ---
>  tests/generic/363 | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/tests/generic/363 b/tests/generic/363
> index 477c111ccb60..74226a458427 100755
> --- a/tests/generic/363
> +++ b/tests/generic/363
> @@ -13,9 +13,6 @@ _begin_fstest rw auto
>  
>  _require_test
>  
> -# currently only xfs performs enough zeroing to satisfy fsx
> -_supported_fs xfs
> -

IIRC pretty much every fs except for xfs failed this test when I wrote
it, so I didn't want to drop it on folks until I had a chance to look
into it. I had pending ext4 fixes which appear to have now been merged,
so on a quick test of -rc2 this now passes on ext4.

I haven't got to the others, but if it's particularly disruptive for
anybody I suppose it could still be excluded easy enough:

Reviewed-by: Brian Foster <bfoster@...hat.com>

>  # on failure, replace -q with -d to see post-eof writes in the dump output
>  run_fsx "-q -S 0 -e 1 -N 100000"
>  
> -- 
> 2.45.2
> 
>