linux-ext4 - Re: [PATCH v8 16/19] fsnotify: generate pre-content permission event on page fault

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241211163006.2r2mxe7vddzgk7ka@quack3>
Date: Wed, 11 Dec 2024 17:30:06 +0100
From: Jan Kara <jack@...e.cz>
To: Randy Dunlap <rdunlap@...radead.org>
Cc: Klara Modin <klarasmodin@...il.com>, Josef Bacik <josef@...icpanda.com>,
	kernel-team@...com, linux-fsdevel@...r.kernel.org, jack@...e.cz,
	amir73il@...il.com, brauner@...nel.org,
	torvalds@...ux-foundation.org, viro@...iv.linux.org.uk,
	linux-xfs@...r.kernel.org, linux-btrfs@...r.kernel.org,
	linux-mm@...ck.org, linux-ext4@...r.kernel.org
Subject: Re: [PATCH v8 16/19] fsnotify: generate pre-content permission event
 on page fault

On Tue 10-12-24 13:12:01, Randy Dunlap wrote:
> On 12/8/24 8:58 AM, Klara Modin wrote:
> >> +/**
> >> + * filemap_fsnotify_fault - maybe emit a pre-content event.
> >> + * @vmf:    struct vm_fault containing details of the fault.
> >> + * @folio:    the folio we're faulting in.
> >> + *
> >> + * If we have a pre-content watch on this file we will emit an event for this
> >> + * range.  If we return anything the fault caller should return immediately, we
> >> + * will return VM_FAULT_RETRY if we had to emit an event, which will trigger the
> >> + * fault again and then the fault handler will run the second time through.
> >> + *
> >> + * This is meant to be called with the folio that we will be filling in to make
> >> + * sure the event is emitted for the correct range.
> >> + *
> >> + * Return: a bitwise-OR of %VM_FAULT_ codes, 0 if nothing happened.
> >> + */
> >> +vm_fault_t filemap_fsnotify_fault(struct vm_fault *vmf)
> > 
> > The parameters mentioned above do not seem to match with the function.
> 
> 
> which causes a warning:
> 
> mm/filemap.c:3289: warning: Excess function parameter 'folio' description in 'filemap_fsnotify_fault'

Thanks, fixed up!

								Honza
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR