linux-ext4 - Re: [RFC 3/3] xfs_io: add extsize command support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z1rRQdKs/9lHT6P7@li-bb2b2a4c-3307-11b2-a85c-8fa5c3a69313.ibm.com>
Date: Thu, 12 Dec 2024 17:34:17 +0530
From: Ojaswin Mujoo <ojaswin@...ux.ibm.com>
To: "Darrick J. Wong" <djwong@...nel.org>
Cc: linux-ext4@...r.kernel.org, linux-xfs@...r.kernel.org,
        Ritesh Harjani <ritesh.list@...il.com>, linux-kernel@...r.kernel.org,
        linux-fsdevel@...r.kernel.org,
        Andrey Albershteyn <aalbersh@...nel.org>,
        John Garry <john.g.garry@...cle.com>
Subject: Re: [RFC 3/3] xfs_io: add extsize command support

On Wed, Dec 11, 2024 at 10:18:27AM -0800, Darrick J. Wong wrote:
> On Wed, Dec 11, 2024 at 01:24:04PM +0530, Ojaswin Mujoo wrote:
> > extsize command is currently only supported with XFS filesystem.
> > Lift this restriction now that ext4 is also supporting extsize hints.
> > 
> > Signed-off-by: Ojaswin Mujoo <ojaswin@...ux.ibm.com>
> 
> Seems pretty straightforward to me.  Are you planning to add an extsize
> option to chattr?

Do you mean e2fsprogs? If so, then yes we'll add it there eventually
however for now I only have xfs_io patches since I was working on them 
to make the extsize xfstests work with ext4.

Regards,
ojaswin
> 
> Reviewed-by: "Darrick J. Wong" <djwong@...nel.org>
> 
> --D
> 
> > ---
> >  io/open.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/io/open.c b/io/open.c
> > index a30dd89a1fd5..2582ff9b862e 100644
> > --- a/io/open.c
> > +++ b/io/open.c
> > @@ -997,7 +997,7 @@ open_init(void)
> >  	extsize_cmd.args = _("[-D | -R] [extsize]");
> >  	extsize_cmd.argmin = 0;
> >  	extsize_cmd.argmax = -1;
> > -	extsize_cmd.flags = CMD_NOMAP_OK;
> > +	extsize_cmd.flags = CMD_NOMAP_OK | CMD_FOREIGN_OK;
> >  	extsize_cmd.oneline =
> >  		_("get/set preferred extent size (in bytes) for the open file");
> >  	extsize_cmd.help = extsize_help;
> > -- 
> > 2.43.5
> > 
> >