linux-ext4 - Re: [RFC 1/3] include/linux.h: Factor out generic platform_test_fs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z1vMrUqBWcarQ6_s@infradead.org>
Date: Thu, 12 Dec 2024 21:57:01 -0800
From: Christoph Hellwig <hch@...radead.org>
To: "Darrick J. Wong" <djwong@...nel.org>
Cc: Ojaswin Mujoo <ojaswin@...ux.ibm.com>, linux-ext4@...r.kernel.org,
	linux-xfs@...r.kernel.org, Ritesh Harjani <ritesh.list@...il.com>,
	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	Andrey Albershteyn <aalbersh@...nel.org>,
	John Garry <john.g.garry@...cle.com>
Subject: Re: [RFC 1/3] include/linux.h: Factor out generic
 platform_test_fs_fd() helper

On Wed, Dec 11, 2024 at 10:09:02AM -0800, Darrick J. Wong wrote:
> > +
> > +static __inline__ int platform_test_ext4_fd(int fd)
> > +{
> > +	return platform_test_fs_fd(fd, 0xef53); /* EXT4 magic number */
> 
> Should this be pulling EXT4_SUPER_MAGIC from linux/magic.h?

I think we can just drop adding platform_test_ext4_fd with the
suggested patches later in the series?  Having ext4-specific code
in xfsprogs would seem pretty odd in xfsprogs anyway over our previous
categories of xfs only or generic.