linux-ext4 - [PATCH 2/6] ext4: remove unneeded bits mask in dx_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20241219110027.1440876-3-shikemeng@huaweicloud.com>
Date: Thu, 19 Dec 2024 19:00:23 +0800
From: Kemeng Shi <shikemeng@...weicloud.com>
To: tytso@....edu,
	adilger.kernel@...ger.ca
Cc: linux-ext4@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: [PATCH 2/6] ext4: remove unneeded bits mask in dx_get_block()

As high four bits of block in dx_entry is not used by any feature for now,
we can remove unneeded bits mask in dx_get_block() and add it back when
it's really needed.

Signed-off-by: Kemeng Shi <shikemeng@...weicloud.com>
---
 fs/ext4/namei.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
index adec145b6f7d..8ff840ef4730 100644
--- a/fs/ext4/namei.c
+++ b/fs/ext4/namei.c
@@ -561,14 +561,9 @@ ext4_next_entry(struct ext4_dir_entry_2 *p, unsigned long blocksize)
 		ext4_rec_len_from_disk(p->rec_len, blocksize));
 }
 
-/*
- * Future: use high four bits of block for coalesce-on-delete flags
- * Mask them off for now.
- */
-
 static inline ext4_lblk_t dx_get_block(struct dx_entry *entry)
 {
-	return le32_to_cpu(entry->block) & 0x0fffffff;
+	return le32_to_cpu(entry->block);
 }
 
 static inline void dx_set_block(struct dx_entry *entry, ext4_lblk_t value)
-- 
2.30.0