lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20241219155532.GF6174@frogsfrogsfrogs> Date: Thu, 19 Dec 2024 07:55:32 -0800 From: "Darrick J. Wong" <djwong@...nel.org> To: Ojaswin Mujoo <ojaswin@...ux.ibm.com> Cc: linux-ext4@...r.kernel.org, linux-xfs@...r.kernel.org, Ritesh Harjani <ritesh.list@...il.com>, linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org, Andrey Albershteyn <aalbersh@...nel.org>, Christoph Hellwig <hch@....de> Subject: Re: [PATCH v2 1/3] include/linux.h: use linux/magic.h to get XFS_SUPER_MAGIC On Thu, Dec 19, 2024 at 06:09:13PM +0530, Ojaswin Mujoo wrote: > This avoids open coding the magic number > > Reviewed-by: Christoph Hellwig <hch@....de> > Signed-off-by: Ojaswin Mujoo <ojaswin@...ux.ibm.com> Looks reasonable, Reviewed-by: "Darrick J. Wong" <djwong@...nel.org> --D > --- > include/linux.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/include/linux.h b/include/linux.h > index e9eb7bfb26a1..b3516d54c51b 100644 > --- a/include/linux.h > +++ b/include/linux.h > @@ -37,6 +37,7 @@ > #endif > #include <unistd.h> > #include <assert.h> > +#include <linux/magic.h> /* super block magic numbers */ > > static __inline__ int xfsctl(const char *path, int fd, int cmd, void *p) > { > @@ -60,7 +61,7 @@ static __inline__ int platform_test_xfs_fd(int fd) > return 0; > if (!S_ISREG(statbuf.st_mode) && !S_ISDIR(statbuf.st_mode)) > return 0; > - return (statfsbuf.f_type == 0x58465342); /* XFSB */ > + return statfsbuf.f_type == XFS_SUPER_MAGIC; > } > > static __inline__ int platform_test_xfs_path(const char *path) > -- > 2.43.5 > >
Powered by blists - more mailing lists