linux-ext4 - [PATCH 0/5] ext4: fix issues caused by data write-back failures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20241220060757.1781418-1-libaokun@huaweicloud.com>
Date: Fri, 20 Dec 2024 14:07:52 +0800
From: libaokun@...weicloud.com
To: linux-ext4@...r.kernel.org
Cc: tytso@....edu,
	adilger.kernel@...ger.ca,
	jack@...e.cz,
	linux-kernel@...r.kernel.org,
	yi.zhang@...wei.com,
	yangerkun@...wei.com,
	libaokun@...weicloud.com,
	Baokun Li <libaokun1@...wei.com>
Subject: [PATCH 0/5] ext4: fix issues caused by data write-back failures

From: Baokun Li <libaokun1@...wei.com>

Recently some of our customers remounted ext4 from
"dioread_nolock,data_err=abort" to "dioread_lock,data_err=abort" and the
ext4 filesystem became read-only.

Then I found that "data_err=abort" is not working in dioread_nolock mode,
when data writeback fails, the error is always recorded in inode mapping,
but no one will check it, not even when converting unwritten to written,
which could expose stale data. When remounted with dioread_lock, the error
recorded in the inode mapping was checked and the journal aborted, and the
file system became read-only later.

Patch 1: Clean up duplicate code and ensure that an warning is printed
         when data may be lost;
Patch 2: Fix an issue that could expose stale data when data writeback
         fails;
Patch 3: Make “data_err=abort” works in dioread_nolock mode.
Patch 4: Remove useless i_unwritten and related code.
Patch 5: Pack holes in ext4_inode_info to save memory.

Baokun Li (5):
  ext4: replace opencoded ext4_end_io_end() in ext4_put_io_end()
  ext4: do not convert the unwritten extents if data writeback fails
  ext4: abort journal on data writeback failure if in data_err=abort mode
  ext4: remove unused member 'i_unwritten' from 'ext4_inode_info'
  ext4: pack holes in ext4_inode_info

 fs/ext4/ext4.h    | 32 ++++++++------------------------
 fs/ext4/inode.c   |  2 +-
 fs/ext4/page-io.c | 38 +++++++++++++++++++++++++-------------
 fs/ext4/super.c   |  9 +--------
 4 files changed, 35 insertions(+), 46 deletions(-)

-- 
2.46.1