lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <Z2VoSwYw+sFTzMx0@li-bb2b2a4c-3307-11b2-a85c-8fa5c3a69313.ibm.com> Date: Fri, 20 Dec 2024 18:21:23 +0530 From: Ojaswin Mujoo <ojaswin@...ux.ibm.com> To: Kemeng Shi <shikemeng@...weicloud.com> Cc: tytso@....edu, adilger.kernel@...ger.ca, linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 4/6] ext4: remove unneeded check in get_dx_countlimit On Thu, Dec 19, 2024 at 07:00:25PM +0800, Kemeng Shi wrote: > The "offset" is always non-NULL, remove unneeded NULL check of "offset". > > Signed-off-by: Kemeng Shi <shikemeng@...weicloud.com> Hi Kemeng, I know the current callers don't pass NULL but I think we should still keep the check around just in case, to avoid NULL dereferences in future. I don't think there's any harm in keeping it Regards, ojaswin > --- > fs/ext4/namei.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c > index 33670cebdedc..07a1bb570deb 100644 > --- a/fs/ext4/namei.c > +++ b/fs/ext4/namei.c > @@ -434,8 +434,7 @@ static struct dx_countlimit *get_dx_countlimit(struct inode *inode, > } else > return NULL; > > - if (offset) > - *offset = count_offset; > + *offset = count_offset; > return (struct dx_countlimit *)(((void *)dirent) + count_offset); > } > > -- > 2.30.0 >
Powered by blists - more mailing lists