linux-ext4 - Re: [PATCH 5/6] ext4: remove unused input "inode" in ext4_find_dest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3aec5085-48f5-476a-8003-05ad5dfa30a1@huaweicloud.com>
Date: Sat, 21 Dec 2024 15:45:48 +0800
From: Zhang Yi <yi.zhang@...weicloud.com>
To: Kemeng Shi <shikemeng@...weicloud.com>
Cc: linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org, tytso@....edu,
 adilger.kernel@...ger.ca
Subject: Re: [PATCH 5/6] ext4: remove unused input "inode" in
 ext4_find_dest_de

On 2024/12/19 19:00, Kemeng Shi wrote:
> Remove unused input "inode" in ext4_find_dest_de.
> 
> Signed-off-by: Kemeng Shi <shikemeng@...weicloud.com>

Looks good to me.

Reviewed-by: Zhang Yi <yi.zhang@...wei.com>

> ---
>  fs/ext4/ext4.h   | 3 +--
>  fs/ext4/inline.c | 2 +-
>  fs/ext4/namei.c  | 5 ++---
>  3 files changed, 4 insertions(+), 6 deletions(-)
> 
> diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
> index bbffb76d9a90..f7cec0de2790 100644
> --- a/fs/ext4/ext4.h
> +++ b/fs/ext4/ext4.h
> @@ -2821,8 +2821,7 @@ extern int ext4_htree_store_dirent(struct file *dir_file, __u32 hash,
>  				struct ext4_dir_entry_2 *dirent,
>  				struct fscrypt_str *ent_name);
>  extern void ext4_htree_free_dir_info(struct dir_private_info *p);
> -extern int ext4_find_dest_de(struct inode *dir, struct inode *inode,
> -			     struct buffer_head *bh,
> +extern int ext4_find_dest_de(struct inode *dir, struct buffer_head *bh,
>  			     void *buf, int buf_size,
>  			     struct ext4_filename *fname,
>  			     struct ext4_dir_entry_2 **dest_de);
> diff --git a/fs/ext4/inline.c b/fs/ext4/inline.c
> index 3536ca7e4fcc..29081a04aef5 100644
> --- a/fs/ext4/inline.c
> +++ b/fs/ext4/inline.c
> @@ -1012,7 +1012,7 @@ static int ext4_add_dirent_to_inline(handle_t *handle,
>  	int		err;
>  	struct ext4_dir_entry_2 *de;
>  
> -	err = ext4_find_dest_de(dir, inode, iloc->bh, inline_start,
> +	err = ext4_find_dest_de(dir, iloc->bh, inline_start,
>  				inline_size, fname, &de);
>  	if (err)
>  		return err;
> diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
> index 07a1bb570deb..aee1858e6482 100644
> --- a/fs/ext4/namei.c
> +++ b/fs/ext4/namei.c
> @@ -2024,8 +2024,7 @@ static struct ext4_dir_entry_2 *do_split(handle_t *handle, struct inode *dir,
>  	return ERR_PTR(err);
>  }
>  
> -int ext4_find_dest_de(struct inode *dir, struct inode *inode,
> -		      struct buffer_head *bh,
> +int ext4_find_dest_de(struct inode *dir, struct buffer_head *bh,
>  		      void *buf, int buf_size,
>  		      struct ext4_filename *fname,
>  		      struct ext4_dir_entry_2 **dest_de)
> @@ -2111,7 +2110,7 @@ static int add_dirent_to_buf(handle_t *handle, struct ext4_filename *fname,
>  		csum_size = sizeof(struct ext4_dir_entry_tail);
>  
>  	if (!de) {
> -		err = ext4_find_dest_de(dir, inode, bh, bh->b_data,
> +		err = ext4_find_dest_de(dir, bh, bh->b_data,
>  					blocksize - csum_size, fname, &de);
>  		if (err)
>  			return err;