linux-ext4 - Re: [PATCH 1/6] ext4: add missing brelse for bh2 in ext4_dx_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e6173110-7225-6cff-762f-f49bc0df30cb@huaweicloud.com>
Date: Tue, 24 Dec 2024 20:11:12 +0800
From: Kemeng Shi <shikemeng@...weicloud.com>
To: Markus Elfring <Markus.Elfring@....de>, linux-ext4@...r.kernel.org,
 Andreas Dilger <adilger.kernel@...ger.ca>, Theodore Ts'o <tytso@....edu>
Cc: linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 1/6] ext4: add missing brelse for bh2 in ext4_dx_add_entry



on 12/20/2024 9:15 PM, Markus Elfring wrote:
>> Add missing brelse for bh2 in ext4_dx_add_entry.
> 
> * I propose to append parentheses to function names.
> 
> * How do you think about to add any tags (like “Fixes” and “Cc”) accordingly?
>   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.13-rc3#n145
Sure, will handle these in next version.

Thanks,
Kemeng
> 
> 
> …
>> +++ b/fs/ext4/namei.c
>> @@ -2580,8 +2580,10 @@ static int ext4_dx_add_entry(handle_t *handle, struct ext4_filename *fname,
>>  		BUFFER_TRACE(frame->bh, "get_write_access");
>>  		err = ext4_journal_get_write_access(handle, sb, frame->bh,
>>  						    EXT4_JTR_NONE);
>> -		if (err)
>> +		if (err) {
>> +			brelse(bh2);
>>  			goto journal_error;
>> +		}
>>  		if (!add_level) {
> …
> 
> I suggest to add another jump target instead so that a bit of exception handling
> can be better reused at the end of this function implementation.
> 
> Regards,
> Markus
>