linux-ext4 - Re: [PATCH 2/3] common: remove the $FSYP check in _cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250128191442.GP3557695@frogsfrogsfrogs>
Date: Tue, 28 Jan 2025 11:14:42 -0800
From: "Darrick J. Wong" <djwong@...nel.org>
To: Christoph Hellwig <hch@....de>
Cc: Zorro Lang <zlang@...nel.org>, Brian Foster <bfoster@...hat.com>,
	fstests@...r.kernel.org, linux-ext4@...r.kernel.org
Subject: Re: [PATCH 2/3] common: remove the $FSYP check in _cleanup_dump

On Tue, Jan 28, 2025 at 08:12:59AM +0100, Christoph Hellwig wrote:
> Despite the comment, _cleanup_dump is only called from xfs specific
> tests, so this is superfluous.
> 
> Signed-off-by: Christoph Hellwig <hch@....de>

This patch looks ok, but I have a few extra[neous] comments...
Reviewed-by: "Darrick J. Wong" <djwong@...nel.org>

> ---
>  common/dump | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/common/dump b/common/dump
> index 50b2ba03c670..3761c16100d8 100644
> --- a/common/dump
> +++ b/common/dump
> @@ -223,12 +223,6 @@ _require_tape()
>  #
>  _cleanup_dump()
>  {
> -    # Some tests include this before checking _supported_fs xfs
> -    # and the sleeps & checks here get annoying
> -    if [ "$FSTYP" != "xfs" ]; then
> -       return
> -    fi
> -

I went looking in common/dump and I noticed the lack of an explicit
setup routine.  Instead, variables and _require calls are done when
sourcing the file.  Curiously there's no check for FSTYP==xfs, which I
guess is reasonable for sourced stuff, but I think that should all get
pulled up into _init_dump() or something.

The other thing I noticed is that sourcing common/dump deletes
$seqres.full, which seems like a real bug.

--D

>      cd $here
>  
>      if [ -n "$DEBUGDUMP" ]; then
> -- 
> 2.45.2
> 
>