linux-ext4 - Re: [PATCH 2/3] common: remove the $FSYP check in _cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250129052731.GB28665@lst.de>
Date: Wed, 29 Jan 2025 06:27:31 +0100
From: Christoph Hellwig <hch@....de>
To: "Darrick J. Wong" <djwong@...nel.org>
Cc: Christoph Hellwig <hch@....de>, Zorro Lang <zlang@...nel.org>,
	Brian Foster <bfoster@...hat.com>, fstests@...r.kernel.org,
	linux-ext4@...r.kernel.org
Subject: Re: [PATCH 2/3] common: remove the $FSYP check in _cleanup_dump

On Tue, Jan 28, 2025 at 11:14:42AM -0800, Darrick J. Wong wrote:
> I went looking in common/dump and I noticed the lack of an explicit
> setup routine.  Instead, variables and _require calls are done when
> sourcing the file.  Curiously there's no check for FSTYP==xfs, which I
> guess is reasonable for sourced stuff, but I think that should all get
> pulled up into _init_dump() or something.
> 
> The other thing I noticed is that sourcing common/dump deletes
> $seqres.full, which seems like a real bug.

Yeah, dump testing is at least as messy as xfsdump itself :)

Btw, did someone every spend some time analyzing why xfs/059 xfs/060
fail relatively frequently when using RT devices?  This is one of the
thing on my TODO list when I find a little more time..