linux-ext4 - Re: [PATCH 1/2] jbd2: Remove wrong sb->s

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56423ecf-3ded-43ed-8270-0f62aa085316@huaweicloud.com>
Date: Tue, 11 Feb 2025 11:13:07 +0800
From: Zhang Yi <yi.zhang@...weicloud.com>
To: Jan Kara <jack@...e.cz>
Cc: linux-ext4@...r.kernel.org, stable@...r.kernel.org,
 Ted Tso <tytso@....edu>
Subject: Re: [PATCH 1/2] jbd2: Remove wrong sb->s_sequence check

On 2025/2/6 17:46, Jan Kara wrote:
> Journal emptiness is not determined by sb->s_sequence == 0 but rather by
> sb->s_start == 0 (which is set a few lines above). Furthermore 0 is a
> valid transaction ID so the check can spuriously trigger. Remove the
> invalid WARN_ON.
> 
> CC: stable@...r.kernel.org
> Signed-off-by: Jan Kara <jack@...e.cz>

This is indeed subtle, it looks good to me.

Reviewed-by: Zhang Yi <yi.zhang@...wei.com>

> ---
>  fs/jbd2/journal.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c
> index 7e49d912b091..354c9f691df3 100644
> --- a/fs/jbd2/journal.c
> +++ b/fs/jbd2/journal.c
> @@ -1879,7 +1879,6 @@ int jbd2_journal_update_sb_log_tail(journal_t *journal, tid_t tail_tid,
>  
>  	/* Log is no longer empty */
>  	write_lock(&journal->j_state_lock);
> -	WARN_ON(!sb->s_sequence);
>  	journal->j_flags &= ~JBD2_FLUSHED;
>  	write_unlock(&journal->j_state_lock);
>