linux-ext4 - Re: [RFC 4/5] check,common/config: Add support for central fsconfig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4c951390-400a-48ce-824c-f075a37496a9@oracle.com>
Date: Thu, 20 Feb 2025 17:56:22 +0800
From: Anand Jain <anand.jain@...cle.com>
To: "Nirjhar Roy (IBM)" <nirjhar.roy.lists@...il.com>, fstests@...r.kernel.org
Cc: linux-ext4@...r.kernel.org, linux-xfs@...r.kernel.org,
        ritesh.list@...il.com, ojaswin@...ux.ibm.com, djwong@...nel.org,
        zlang@...nel.org
Subject: Re: [RFC 4/5] check,common/config: Add support for central fsconfig

On 10/1/25 17:10, Nirjhar Roy (IBM) wrote:
> This adds support to pick and use any existing FS config from
> configs/<fstype>/<config>. e.g.
> 
> configs/xfs/1k
> configs/xfs/4k
> configs/ext4/4k
> configs/ext4/64k
> 
> This should help us maintain and test different fs test
> configurations from a central place. We also hope that
> this will be useful for both developers and testers to
> look into what is being actively maintained and tested
> by FS Maintainers.
> 
> When we will have fsconfigs set, then will be another subdirectory created
> in results/<section>. For example let's look at the following:
> 
> The directory tree structure on running
> sudo ./check -q 2 -R xunit-quiet -c xfs/4k,configs/xfs/1k selftest/001 selftest/007
> 


The -c option check makes sense to me. Is it possible to get this
feature implemented first while the -q option is still under discussion?

That said, I have a suggestion for the -c option—
  Global config variables should be overridden by file system-specific 
config files.

For example, if configs/localhost.config contains:

MKFS_OPTIONS="--sectorsize 64K"

but configs/<fstype>/some_config sets:

MKFS_OPTIONS=""

then the value from configs/<fstype>/some_config should take priority.

I ran some tests with btrfs, and I don’t see this behavior happening yet.

Thanks, Anand